I am upgrading the old contract from 0.4.24 for new solidity compiler version 0.5.16 and i've found some problems,
I've found the contract code address(this) however the compiler keep telling me to make the type "address payable".
How should I make it?
Here is the full code
pragma solidity ^0.5.16;
library SafeMath {
function add(uint256 a, uint256 b) internal pure returns (uint256) {
uint256 c = a + b;
require(c >= a, "SafeMath: addition overflow");
return c;
}
function sub(uint256 a, uint256 b) internal pure returns (uint256) {
return sub(a, b, "SafeMath: subtraction overflow");
}
function sub(uint256 a, uint256 b, string memory errorMessage) internal pure returns (uint256) {
require(b <= a, errorMessage);
uint256 c = a - b;
return c;
}
function mul(uint256 a, uint256 b) internal pure returns (uint256) {
if (a == 0) {
return 0;
}
uint256 c = a * b;
require(c / a == b, "SafeMath: multiplication overflow");
return c;
}
function div(uint256 a, uint256 b) internal pure returns (uint256) {
return div(a, b, "SafeMath: division by zero");
}
function div(uint256 a, uint256 b, string memory errorMessage) internal pure returns (uint256) {
require(b > 0, errorMessage);
uint256 c = a / b;
return c;
}
function mod(uint256 a, uint256 b) internal pure returns (uint256) {
return mod(a, b, "SafeMath: modulo by zero");
}
function mod(uint256 a, uint256 b, string memory errorMessage) internal pure returns (uint256) {
require(b != 0, errorMessage);
return a % b;
}
}
contract Staking {
// NOTE: The contract only works for intervals of time > round_interval
using SafeMath for uint;
event StartStaking(address addr, uint value, uint amount, uint time);
event WithdrawStake(address staker, uint amount);
event Claim(address staker, uint reward);
event DonationDeposited(address _address, uint value);
struct Staker
{
uint amount;
uint time;
}
uint public LastBlock = block.number;
uint public Timestamp = now; //timestamp of the last interaction with the contract.
uint public TotalStakingWeight; //total weight = sum (each_staking_amount * each_staking_time).
uint public TotalStakingAmount; //currently frozen amount for Staking.
uint public StakingRewardPool; //available amount for paying rewards.
bool public CS_frozen; //Cold Staking frozen.
uint public staking_threshold = 0 ether;
address public Treasury = 0x3c06f218Ce6dD8E2c535a8925A2eDF81674984D9; // Callisto Staking Reserve address.
uint public round_interval = 27 days; // 1 month.
uint public max_delay = 365 * 2 days;// 2 years.
uint public DateStartStaking = 1541980800; // 12.11.2018 0:0:0 UTC.
//========== TESTNET VALUES ===========
//uint public round_interval = 10 minutes;
//uint public max_delay = 2 days;
//uint public DateStartStaking = 0;
//========== END TEST VALUES ==========
mapping(address => Staker) public staker;
function freeze(bool _f) public only_treasurer
{
CS_frozen = _f;
}
function withdraw_rewards () public only_treasurer
{
if (CS_frozen)
{
StakingRewardPool = address(this).balance.sub(TotalStakingAmount);
Treasury.transfer(StakingRewardPool);
}
}
function clear_treasurer () public only_treasurer
{
require(block.number > 1800000 && !CS_frozen);
Treasury = 0x00;
}
function() external payable
{
// No donations accepted to fallback!
// Consider value deposit is an attempt to become staker.
// May not accept deposit from other contracts due GAS limit.
start_staking();
}
// this function can be called for manualy update TotalStakingAmount value.
function new_block() public
{
if (block.number > LastBlock) //run once per block.
{
uint _LastBlock = LastBlock;
LastBlock = block.number;
StakingRewardPool = address(this).balance.sub(TotalStakingAmount + msg.value); //fix rewards pool for this block.
// msg.value here for case new_block() is calling from start_staking(), and msg.value will be added to CurrentBlockDeposits.
//The consensus protocol enforces block timestamps are always atleast +1 from their parent, so a node cannot "lie into the past".
if (now > Timestamp) //But with this condition I feel safer :) May be removed.
{
uint _blocks = block.number - _LastBlock;
uint _seconds = now - Timestamp;
if (_seconds > _blocks * 25) //if time goes far in the future, then use new time as 25 second * blocks.
{
_seconds = _blocks * 25;
}
TotalStakingWeight += _seconds.mul(TotalStakingAmount);
Timestamp += _seconds;
}
}
}
function start_staking() public staking_available payable
{
assert(msg.value >= staking_threshold);
new_block(); //run once per block.
// claim reward if available.
if (staker[msg.sender].amount > 0)
{
if (Timestamp >= staker[msg.sender].time + round_interval)
{
claim();
}
TotalStakingWeight = TotalStakingWeight.sub((Timestamp.sub(staker[msg.sender].time)).mul(staker[msg.sender].amount)); // remove from Weight
}
TotalStakingAmount = TotalStakingAmount.add(msg.value);
staker[msg.sender].time = Timestamp;
staker[msg.sender].amount = staker[msg.sender].amount.add(msg.value);
emit StartStaking(
msg.sender,
msg.value,
staker[msg.sender].amount,
staker[msg.sender].time
);
}
function DEBUG_donation() public payable {
emit DonationDeposited(msg.sender, msg.value);
}
function withdraw_stake() public only_staker
{
new_block(); //run once per block.
require(Timestamp >= staker[msg.sender].time + round_interval); //reject withdrawal before complete round.
uint _amount = staker[msg.sender].amount;
// claim reward if available.
claim();
TotalStakingAmount = TotalStakingAmount.sub(_amount);
TotalStakingWeight = TotalStakingWeight.sub((Timestamp.sub(staker[msg.sender].time)).mul(staker[msg.sender].amount)); // remove from Weight.
staker[msg.sender].amount = 0;
msg.sender.transfer(_amount);
emit WithdrawStake(msg.sender, _amount);
}
//claim rewards
function claim() public only_staker
{
if (CS_frozen) return; //Don't pay rewards when Cold Staking frozen.
new_block(); //run once per block
uint _StakingInterval = Timestamp.sub(staker[msg.sender].time); //time interval of deposit.
if (_StakingInterval >= round_interval)
{
uint _CompleteRoundsInterval = (_StakingInterval / round_interval).mul(round_interval); //only complete rounds.
uint _StakerWeight = _CompleteRoundsInterval.mul(staker[msg.sender].amount); //Weight of completed rounds.
uint _reward = StakingRewardPool.mul(_StakerWeight).div(TotalStakingWeight); //StakingRewardPool * _StakerWeight/TotalStakingWeight
StakingRewardPool = StakingRewardPool.sub(_reward);
TotalStakingWeight = TotalStakingWeight.sub(_StakerWeight); // remove paid Weight.
staker[msg.sender].time = staker[msg.sender].time.add(_CompleteRoundsInterval); // reset to paid time, staking continue without a loss of incomplete rounds.
msg.sender.transfer(_reward);
emit Claim(msg.sender, _reward);
}
}
//This function may be used for info only. This can show estimated user reward at current time.
function stake_reward(address _addr) public view returns (uint)
{
require(staker[_addr].amount > 0);
require(!CS_frozen);
uint _blocks = block.number - LastBlock;
uint _seconds = now - Timestamp;
if (_seconds > _blocks * 25) //if time goes far in the future, then use new time as 25 second * blocks.
{
_seconds = _blocks * 25;
}
uint _Timestamp = Timestamp + _seconds;
uint _TotalStakingWeight = TotalStakingWeight + _seconds.mul(TotalStakingAmount);
uint _StakingInterval = _Timestamp.sub(staker[_addr].time); //time interval of deposit.
//uint _StakerWeight = _StakingInterval.mul(staker[_addr].amount); //Staker weight.
uint _CompleteRoundsInterval = (_StakingInterval / round_interval).mul(round_interval); //only complete rounds.
uint _StakerWeight = _CompleteRoundsInterval.mul(staker[_addr].amount); //Weight of completed rounds.
uint _StakingRewardPool = address(this).balance.sub(TotalStakingAmount);
return _StakingRewardPool.mul(_StakerWeight).div(_TotalStakingWeight); //StakingRewardPool * _StakerWeight/TotalStakingWeight
}
modifier only_staker
{
require(staker[msg.sender].amount > 0);
_;
}
modifier staking_available
{
require(now >= DateStartStaking && !CS_frozen);
_;
}
modifier only_treasurer
{
require(msg.sender == Treasury);
_;
}
//return deposit to inactive staker.
function report_abuse(address _addr) public only_staker
{
require(staker[_addr].amount > 0);
new_block(); //run once per block.
require(Timestamp > staker[_addr].time.add(max_delay));
uint _amount = staker[_addr].amount;
TotalStakingAmount = TotalStakingAmount.sub(_amount);
TotalStakingWeight = TotalStakingWeight.sub((Timestamp.sub(staker[_addr].time)).mul(_amount)); // remove from Weight.
staker[_addr].amount = 0;
_addr.transfer(_amount);
}
}
Thanks in advance.