0

This question already has an answer here:

I have one variable on a smart contract called count, every function call, i put one more value on her.

count++;

What's happening if my variable on smart contract arrives at your limit?

2^256 -1 ?

How i treat this ?

marked as duplicate by Linmao Song, Richard Horrocks, shane, Ismael, Nicolas Massart Jun 10 at 10:10

This question has been asked before and already has an answer. If those answers do not fully address your question, please ask a new question.

1

I voted for Amal's answer and Linmao's comment because they both provide useful information.

It shouldn't be a concern for you in this case because you say the counter is incremented with counter++.

It will not reach the maximum value before an unreasonably large number of transactions. In decimal, 2^256 is 1.1570e+77. Assuming the count starts at zero, it's doubtful there will ever be that many transactions, and someone would have to pay gas for every one of them. That scenario isn't realistic, so the counter is financially and practically constrained.

When doing math, you should always be watchful for overflow/underflow possibilities and be aware that 2^256+1 is 0, like your car's odometer rolling over. Similarly, an unsigned integer 0-1 is a very large number, 2^256.

Think about what bounds or limits the range of possible inputs. For example, if you are accumulating a total of ETH owned by the contract, you might reason that it can't possibly exceed the total ETH in existence. If you aren't sure there is no way to overflow/underflow a calculation, use SafeMath to catch and reject all transactions that threaten to cause overflow/underflow.

Use SafeMath to err on the side of caution.

Consider a habit of using SafeMath in all cases as you iterate over designs. It provides nice safety precautions. Consider not using SafeMath as a modest optimization if you are absolutely sure a given operation cannot overflow/underflow in any scenario.

Hope it helps.

1

Nice! You've identified overflow as a point of concern. Take a look at Open Zeppelin for general guidance and a starting point for best practices. For overflows, consider their SafeMath contract

Not the answer you're looking for? Browse other questions tagged or ask your own question.