Warning: Unreachable code in for loop in solidity version 0.5.3

Question

As soon as I upgraded the code from solidity version 0.5.2 to 0.5.3, it showing warning in my for loop.

Warning: Unreachable code.
for(uint256 i=0; i < totalHoldTransactions; i++ ){
                                            ^-^

This SO article which gives idea in other programming languages. But I am still not sure why that increment variable is unreachable!

Any ideas will be appreciated. Thanks.

Answer 1

After lots of research the culprit was the return statement inside the loop. So to anyone has this issue, you need to move any code outside of the for loop which causes it to bounce.

 for(uint256 i=0; i < totalHoldTransactions; i++ ){
       //other code..
       if(i >= 10){ break; }

       return true;  //this was the issue. I moved it to outside of loop and everything worked!!

    }