contract address returning as null value

Question

I am trying to create a factory contract and storing the smart contract address in an array but when I trying to retrieve the value, it always gives null value. Please find the contracts that I have used below.

pragma solidity ^0.4.7;

contract ContractTest {
    bytes32 public Name;

    function ContractTest (bytes32 name) {
        Name = name;
    }
}


pragma solidity ^0.4.7;
import './ContractTest.sol';

contract FactoryTest{
    address[2] newContracts;

    function createContract (bytes32 name) {
        address newContract = new ContractTest(name);
        newContracts[0]=newContract;
    }
        function getContract() returns(address) {
          return newContracts[0];
        }
}

Answer 1

With a bit of refactoring and reformatting, I ended up with this code:

pragma solidity ^0.4.7;

contract ContractTest { 
    string public Name;

    function ContractTest (string name) {
        Name = name;
    }
}

contract FactoryTest { 
    address[2] newContracts;

    function createContract (string name) {
        address newContract = new ContractTest(name);
        newContracts[0]=newContract;
    }

    function getContract() returns(address) {
      return newContracts[0];
    }
}

The only real change is the use of string instead of bytes. I was testing it in Remix and I couldn't get it to accept input as bytes so I changed the input type.

The code above works just fine. So either the problem is somehow with the bytes or then you are testing it wrong.

Answer 2

How are you calling getContract? From solidity or javascript.

The function getContract is not declared as view, for example if you call it from js it will execute it as a transaction and will not return the value you are expecting.

contract FactoryTest { 
    address[2] newContracts;

    function createContract(string name) public {
        address newContract = new ContractTest(name);
        newContracts[0] = newContract;
    }

    function getContract() public view returns (address) {
      return newContracts[0];
    }
}