Gas estimation failed with the function

Question

Before adding this function below, the contract works well. But after adding the function, when I trying to deploy the contract, the remix IDE keeps showing the error message of "Gas estimation failed". Did something wrong with the function?

 //return the user name by mapping the address
    function find_user_name(address _address) public view returns(string){
      uint256 i;
      string account_name;
      for(i=0; i < userlist.length; i++){//find the mapping user account name
            if(_address == userlist[i].useraddress)account_name = userlist[i].account;
      }

      return account_name;
    }

Answer 1

There is nothing wrong in the code. It worked fine for me. Please provide more context and code. If this is the problem when calling the function then you should check validity of the address parameter. But this problem is on deployment so, more context is needed.

You are using array for userlist. Try to change it to mapping with address as key and value be your user struct.

mapping(address => User) userlist;

This has the advantage also you do not have to loop, you can directly get user with user address.