I noticed the new Remix gave me two new warnings:
browser/Untitled.sol:6:5: Warning: No visibility specified. Defaulting to "public".
function setFee(uint _fee){
^
Spanning multiple lines.
and
browser/Untitled.sol:15:3: Warning: Function state mutability can be restricted to pure
function mul(uint256 a, uint256 b) internal constant returns (uint256) {
^
Spanning multiple lines.
Should I change anything? Is it best practice to type out visibility? Here's my simple code:
pragma solidity ^0.4.13;
contract test {
uint public fee;
function setFee(uint _fee){
fee = Sf.mul(_fee,10);
}
}
library Sf{
function mul(uint256 a, uint256 b) internal constant returns (uint256) {
uint256 c = a * b;
assert(a == 0 || c / a == b);
return c;
}
}