buildChainlinkRequest function of Chainlink is not working properly

Question

The buildChainlinkRequest line no 47 takes 3 parameters:

1. JobId
2. Callback Address
3. Function to callback to

I have smartcontract1 and smartcontract2. The below mentioned function is inside smartcontract2

function requestVolumeData(string memory _jobId, string memory addrsss, address callBackContract, bytes4 functionSelector) external returns (bytes32 requestId) {
   
    Chainlink.Request memory req = buildChainlinkRequest(
        stringToBytes32(_jobId),
        callBackContract,
        functionSelector
    );

    req.add("publicKey", addrsss);
    return sendChainlinkRequest(req, fee);
}

Code inside smartcontract1 given below,

interface OracleInterfacehere{
 function requestVolumeData(string memory _jobId, string memory addrsss, address callBackContract, bytes4 functionSelector) external returns (bytes32) ;
}


 function requestingdataFromOracle(string memory _jobId, string memory addrsss, address _smartcontract2) public  {
      OracleInterfacehere OracleOwnerGuard = OracleInterfacehere(_smartcontract2);
      OracleOwnerGuard.requestVolumeData(_jobId, addrsss,address(this), this.fulfill.selector);
 }

  function fulfill(
    bytes32 _requestId,
    bool _status
) public recordChainlinkFulfillment(_requestId) {
    status = _status;
}

What I am expecting is as smartcontract1 call "requestVolumeData" (inside smartcontract2) function, the oracle will send data back to "fulfill" function of smartcontract1. But this is not working as expected

Note : I have followed this approach(Mentioned in the answer by Patrick) StackExchange question

Answer 1

Chainlink.Request memory req = buildChainlinkRequest(
        stringToBytes32(_jobId),
        callBackContract,
        functionSelector
 );

This function is present in the ChainlinkClient contract that you would be using but this is not the issue in the code.

When you call the function sendChainlinkRequest which is also present in the same contract and is the problem.

This functions body actually saves the address from which this function is actually called

bytes memory encodedRequest = abi.encodeWithSelector(
      ChainlinkRequestInterface.oracleRequest.selector,
      SENDER_OVERRIDE, // Sender value - overridden by onTokenTransfer by the requesting contract's address
      AMOUNT_OVERRIDE, // Amount value - overridden by onTokenTransfer by the actual amount of LINK sent
      req.id,
      address(this),
      req.callbackFunctionId,
      nonce,
      ORACLE_ARGS_VERSION,
      req.buf.buf
    );

Answer 2

I'm sorry to hear that the buildChainlinkRequest function is not working properly. Have you tried restarting the application or checking the logs to see if there are any errors? If you are still having trouble, please reach out to the Chainlink support team for more assistance.

Answer 3

Can you remove the recordChainlinkFulfillment() modifier from the fulfill() function? One thing this modifier limits is who can call the function. When you call sendChainlinkRequest, it adds the oracle contract to the allow list.

I believe the issue is that SC2 knows about the address, but SC1 does not.

If you do this, anyone can call fulfill(). If you need to limit that, you could hardcode the oracle address or pass it through from SC2.