mappings return false but function returns true

Question

I have a mapping uint256=>bool. I am giving projectId to see is it registered or not. I registered a project. I use chainlink automation for do something. But when i call checkuppkeep function for testing, mapping returns false but function returns true after registration. Basicly is_funding public view function returns true as it should be but in the contract _isFunding[projectId] mapping return false. What is going on?

_isFunding[projectId] = true;

  function checkUpkeep(
    bytes memory /* checkData */
)
    public
    view
    override
    returns (
        bool upkeepNeeded,
        bytes memory /* performData */
    )
{
    bool isFunded = _isFunding[projectId];
    bool timePassed = (block.timestamp -
        (projectToTime[projectId][time[projectId]])) > time[projectId];
    upkeepNeeded = (isFunded);
}
function getTimeleft(uint256 _projectID)
    public
    view
    returns (uint256 a, uint256 b)
{
    a = block.timestamp - projectToTime[_projectID][time[_projectID]];
    b = time[_projectID];
}
function is_funding(uint256 _projectID) public view returns (bool) {
        return _isFunding[_projectID];
    }

Hardhat test file :

it("return false if project hasnt submit", async () => {
      blockNumber = await ethers.provider.getBlockNumber();
      console.log(`Before ${blockNumber}`);
      await moveTime(s_fundingTime + 1);
      await moveBlocks(s_fundingTime + 1);
      blockNumber = await ethers.provider.getBlockNumber();
      console.log(`Before ${blockNumber}`);
      const { upkeepNeeded } = await governor.checkUpkeep([]);
      const { a, b } = await governor.getTimeleft(projectId);
      console.log(await governor.is_funding(projectId));
      console.log(a.toString(), b.toString());
      console.log(upkeepNeeded);
      // assert(!upkeepNeeded);

console of test result:

Before 226
Moving time...
Moved forward 61 seconds..
Moving blocks...
Before 287
true
121 60
false

Answer 1

I came up like this. I will return data perfomData as projectId so we can work on that projectId on chain.

function checkUpkeep(
    bytes memory /* checkData */
)
    public
    view
    override
    returns (bool upkeepNeeded, bytes memory performData)
{
    for (uint i = 1; i <= projectId; i++) {
        bool isFunded = _isFunding[i];

        console.log("_isFunding= ", _isFunding[i], i);

        bool timePassed = (block.timestamp - (projectToTime[i][time[i]])) >
            time[i];
        upkeepNeeded = (isFunded && timePassed);
        if (upkeepNeeded) {
            performData = abi.encodePacked(i);
            break;
        }
    }
}

This is the my perfromUpKeep func.

 function performUpkeep(bytes calldata performData) external override {
    (bool upkeepNeeded, ) = checkUpkeep("");
    if (!upkeepNeeded) {
        revert FundProject__UpkeepNeeded();
    }
    uint256 ProjectId = uint256(bytes32(performData));
    _isFunding[ProjectId] = false;
    _isApporovedByDao[ProjectId] = false;

    if (projectFunds[ProjectId] > projectFundingGoalAmount[ProjectId]) {
        _ProjectFundingStatus[ProjectId] = ProjectFundingStatus.SUCCESS;
        uint256 fundsToSent = (projectFunds[ProjectId] * daoPercentage) /
            100;
        (bool success, ) = (projectOwnerAddress[ProjectId]).call{
            value: fundsToSent
        }("");
        if (!success) {
            revert FundProject__TransferFailed(projectFunds[ProjectId]);
        }

        emit projectSuccessfullyFunded(ProjectId);
    } else {
        _ProjectFundingStatus[ProjectId] = ProjectFundingStatus.FAILED;
        emit projectFundingFailed(ProjectId);
    }
}

Answer 2

Good, If one project has one time stamp then why to don't use a struct, instead of mapping of mapping. Struct ProjectsInfo {unit timestamp; book idfunded} Mapping (unit=>ProjectsInfo) projectToTime

Also, with this solution, if you want optimization (packing), better to reduce the size of timestamp, like uint248.

Answer 3

Based on your posted code, You call checkUpkeep without the parameter projectId.