ENS refinement before deployment (Swaldman catch)

Question

User @Swaldman made a great catch today and found a bug in ENS auction code:

What are the various ways to fix/prevent this attack vector before deployment?

Without reading all of the details (or trying to understand it) - change _value to actualValue in those 3 places? :-) — Richard Horrocks, Commented Mar 14, 2017 at 18:59

eth · Accepted Answer · 2017-06-11 07:51:58Z

1

The fix is in https://github.com/ethereum/ens/pull/51/files and is as described by the comment by @Richard Horrocks: change _value to actualValue

For example:

} else if (_value > h.value) {

should be:

} else if (actualValue > h.value) {

answered May 20, 2017 at 10:41

eth♦

86.5k53 gold badges287 silver badges411 bronze badges

Whilst this may theoretically answer the question, it would be preferable to include the essential parts of the answer here, and provide the link for reference. :P
– q9f
Commented Jun 7, 2017 at 10:47

Add a comment |

1 Answer 1