Correct way to retrieve all addresses with their relevant tokenIds

Question

I've got a NFT collection with a maxSupply of 1000. All the NFTs have been minted where totalSupply == maxSupply.

What is the best way to retrieve all 1000 addresses along with their relevant tokenIds?

I've tried the below, but the results is not working as expected. Where am I going wrong?

 mapping(uint256 => address) private getMintedAddress;

 function getAllAddresses() public view onlyOwner returns (uint256[] memory) {
    uint256 totalMinted = totalSupply();
    uint256[] memory tokenIds = new uint256[](totalMinted);
    for (uint256 i = 1; i < totalMinted; i++) {
        tokenIds[i] = getMintedAddress[i];
    }
    return tokenIds;
  }

Answer 1

They way you should use your mapping is the other way around.

So you should use:

mapping(uint256 => address) private getMintedAddress;

As this way you can simply retrieve your addresses like this:

uint256 totalMinted = totalSupply();
uint256[] memory tokenIds = new uint256[](totalMinted);

for (uint256 i = 0; i < totalMinted; i++) {
    tokenIds[i] = getMintedAddress[i];
}

Here you will get this error: TypeError: Type address is not implicitly convertible to expected type uint256. tokenIds[i] = getMintedAddress[i];

And that is logical because you are saving the address as a uint now. So to just retrieve all balances in tokenId order you need to have this:

uint256 totalMinted = totalSupply();
address[] memory tokenAddresses = new address[](totalMinted);

for (uint256 i = 0; i < totalMinted; i++) {
    tokenAddresses[i] = getMintedAddress[i];
}

Depending how you increment the tokenIds in your minting function, it could be that you need to change getMintedAddress[i] to getMintedAddress[i + 1]